Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a panic in HAR conversion due to missing length check #760

Merged
merged 3 commits into from
Sep 18, 2018

Conversation

na--
Copy link
Member

@na-- na-- commented Sep 10, 2018

Edit: the root cause of reaching the state with 0 entries was simply using something invalid with the --only flag in k6 convert like the URL instead of the domain name

@codecov-io
Copy link

Codecov Report

Merging #760 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage   63.91%   63.89%   -0.02%     
==========================================
  Files         102      102              
  Lines        8479     8481       +2     
==========================================
  Hits         5419     5419              
- Misses       2699     2701       +2     
  Partials      361      361
Impacted Files Coverage Δ
converter/har/converter.go 17.42% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610245d...6bd228b. Read the comment docs.

@na-- na-- merged commit 460ceba into master Sep 18, 2018
@na-- na-- deleted the har-convert-bounds-check branch September 18, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants