Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the amount of samples the cloud collector sends at once #860

Merged
merged 4 commits into from
Dec 6, 2018

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Dec 6, 2018

No description provided.

@mstoykov mstoykov requested a review from na-- December 6, 2018 10:38
@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #860 into master will increase coverage by 0.12%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   69.96%   70.09%   +0.12%     
==========================================
  Files         111      111              
  Lines        8714     8720       +6     
==========================================
+ Hits         6097     6112      +15     
+ Misses       2221     2214       -7     
+ Partials      396      394       -2
Impacted Files Coverage Δ
stats/cloud/config.go 56.86% <100%> (+2.69%) ⬆️
stats/cloud/collector.go 70.67% <60%> (+3.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e59cb4...8146f71. Read the comment docs.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great test and memory efficient implementation!

@mstoykov mstoykov force-pushed the splitMetricsToCloud branch from acbd8c2 to 0f07cf5 Compare December 6, 2018 13:45
@mstoykov mstoykov merged commit c7cfe26 into master Dec 6, 2018
@mstoykov mstoykov deleted the splitMetricsToCloud branch December 6, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants