Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for invalid HAR files that lack the 'log' root property #861

Merged
merged 2 commits into from
Dec 6, 2018

Conversation

na--
Copy link
Member

@na-- na-- commented Dec 6, 2018

No description provided.

@na-- na-- requested a review from mstoykov December 6, 2018 12:27
@codecov-io
Copy link

Codecov Report

Merging #861 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   69.98%   69.96%   -0.02%     
==========================================
  Files         111      111              
  Lines        8712     8714       +2     
==========================================
  Hits         6097     6097              
- Misses       2220     2221       +1     
- Partials      395      396       +1
Impacted Files Coverage Δ
converter/har/converter.go 64.36% <0%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e398b...0e5056d. Read the comment docs.

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@na-- na-- merged commit 2e59cb4 into master Dec 6, 2018
@na-- na-- deleted the har-nil-log-fix branch December 6, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants