Fix incorrect tracing of corner case HTTP requests #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some details: - Before this, some of the measured metrics could be negative, or in one case - hugely positive (saving a timestamp instead of a duration)... - The changes were first developed and tested in this debug branch: https://github.com/na--/k6/tree/debug-neg-http-measurements - Long term, it seems that a rewrite would be needed, since using atomics to measure these metrics isn't flexible enough. It's practically impossible to measure times correctly when the standard library decides to retry an HTTP/2 request :/
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
==========================================
+ Coverage 70.09% 70.12% +0.03%
==========================================
Files 111 111
Lines 8720 8736 +16
==========================================
+ Hits 6112 6126 +14
- Misses 2214 2215 +1
- Partials 394 395 +1
Continue to review full report at Codecov.
|
mstoykov
reviewed
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some details:
Tracerwould be needed, since using atomics to measure these metrics isn't flexible enough. It's practically impossible to measure times correctly when the standard library decides to retry an HTTP/2 request... :/ These fixes will work for now, but I'll create a new issue about it.This should fix #588 for good.