Fix cloud thresholds #894
Merged
Fix cloud thresholds #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if threshold fails once it marked as failed forever. This is okay for local run because what we actually report at the end is if the last threshold check has failed so this threshold failed marking is not taken into consideration. But the cloud collector and the cloud collector only takes this as the final result. This probably should be fixed in some better way such that the final threshold result is actually given to the collectors to report (if they do) but this is outside the scope of this commit. The fix is simply to mark the threshold as failed every time it is checked this way if it fails once and then it stops failing it will be marked as not failed again.
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
- Coverage 69.83% 69.82% -0.01%
==========================================
Files 112 112
Lines 8777 8776 -1
==========================================
- Hits 6129 6128 -1
Misses 2251 2251
Partials 397 397
Continue to review full report at Codecov.
|
na--
approved these changes
Jan 15, 2019
mstoykov
force-pushed
the
fixCloudThresholds
branch
from
6644b21 to
d5a2d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.