Skip to content

Commit

Permalink
Making linters even happier
Browse files Browse the repository at this point in the history
Signed-off-by: Pete Wall <pete.wall@grafana.com>
  • Loading branch information
petewall committed Oct 5, 2024
1 parent 5f54972 commit 040851a
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 10 deletions.
3 changes: 2 additions & 1 deletion .configs/loki.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
deploymentMode: SingleBinary
loki:
commonConfig:
Expand All @@ -11,7 +12,7 @@ loki:
index:
prefix: loki_index_
period: 24h
object_store: filesystem # we're storing on filesystem so there's no real persistence here.
object_store: filesystem # we're storing on filesystem so there's no real persistence here.
schema: v13
singleBinary:
replicas: 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
-->
# Annotation-based autodiscovery

This example shows how to enable the annotation-based autodiscovery feature, which makes it very simple to add scrape
targets. With this feature enabled, any Kubernetes Pods or Services with the `k8s.grafana.com/scrape` annotation set to
This example shows how to enable the annotation-based autodiscovery feature, which makes it easy to add scrape targets.

Check warning on line 7 in charts/k8s-monitoring/docs/examples/features/annotation-autodiscovery/default/README.md

View workflow job for this annotation

GitHub Actions / runner / alex

[alex] reported by reviewdog 🐶 `easy` may be insensitive, try not to use it easy retext-equality Raw Output: 7:93-7:97 warning `easy` may be insensitive, try not to use it easy retext-equality
With this feature enabled, any Kubernetes Pods or Services with the `k8s.grafana.com/scrape` annotation set to
`true` will be automatically discovered and scraped by the collector. There are several other annotations that can be
used to customize the behavior of the scrape configuration, such as:

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Annotation-based autodiscovery

This example shows how to enable the annotation-based autodiscovery feature, which makes it very simple to add scrape
targets. With this feature enabled, any Kubernetes Pods or Services with the `k8s.grafana.com/scrape` annotation set to
This example shows how to enable the annotation-based autodiscovery feature, which makes it easy to add scrape targets.

Check warning on line 3 in charts/k8s-monitoring/docs/examples/features/annotation-autodiscovery/default/description.txt

View workflow job for this annotation

GitHub Actions / runner / alex

[alex] reported by reviewdog 🐶 `easy` may be insensitive, try not to use it easy retext-equality Raw Output: 3:93-3:97 warning `easy` may be insensitive, try not to use it easy retext-equality
With this feature enabled, any Kubernetes Pods or Services with the `k8s.grafana.com/scrape` annotation set to
`true` will be automatically discovered and scraped by the collector. There are several other annotations that can be
used to customize the behavior of the scrape configuration, such as:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ tests:
- query: count_over_time({cluster="cluster-monitoring-feature-test", job!="integrations/kubernetes/eventhandler"}[1h])
type: logql

# DPM check
# # DPM check
# - query: avg(count_over_time(scrape_samples_scraped{cluster="cluster-monitoring-feature-test"}[1m]))
# type: promql
# expect:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ tests:
- query: count_over_time({cluster="control-plane-monitoring-test", job!="integrations/kubernetes/eventhandler"}[1h])
type: logql

# DPM check
# # DPM check
# - query: "avg(count_over_time(scrape_samples_scraped{cluster=\"control-plane-monitoring-test\"}[1m]))"
# type: promql
# expect:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
---
alloy:
enabled: false
#pyroscope:
# extraArgs:
# "auth.multitenancy-enabled": true

0 comments on commit 040851a

Please sign in to comment.