Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow adding extra outputs #640

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidspek
Copy link

Inspired by #608, this PR adds the ability to specify extra outputs both for the batch processor receiver, as well as at the last stage for metrics and logs after all processing has been done. The use case for this is for a simple way to duplicate metrics, logs and traces across multiple backends. A more complex implementation could be to have the externalServices.* values be an array, but that would make the chart much more complicated. Instead, users can use the extraConfig value to configure any additional outputs that are then referenced in these new settings.

Example:

# values.yaml
receivers:
  processors:
    batch:
      output:
        metrics: [otelcol.exporter.kafka.kafka.input]
        logs: [otelcol.exporter.kafka.kafka.input]
        traces: [otelcol.exporter.kafka.kafka.input]
externalServices:
  prometheus:
    extraOutputs: [otelcol.exporter.otlp.duplicate.input]
  loki:
    extraOutputs: [otelcol.exporter.otlp.duplicate.input]

Signed-off-by: David van der Spek <david.vanderspek@flyrlabs.com>
Signed-off-by: David van der Spek <david.vanderspek@flyrlabs.com>
@@ -757,9 +763,6 @@
"enabled": {
"type": "boolean"
},
"extraConfig": {
"type": "string"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason behind removing this one here?

@petewall petewall added this to the 2.0 milestone Sep 11, 2024
@petewall petewall self-requested a review as a code owner October 4, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants