Move extraConfigs into the alloy targets #646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petewall
requested review from
a team,
skl,
nevermind89x and
jewbetcha
and removed request for
a team
skl
approved these changes
Jul 22, 2024
…xamples including the readmes Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
petewall
force-pushed
the
feat/extraConfigs-in-alloy
branch
from
0354f7c
to
7a1509e
Compare
…to NOTES.txt Signed-off-by: Pete Wall <pete.wall@grafana.com>
|
Closing this. This is happening in v2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, this will eventually be a breaking change that will affect serviceIntegrations. I'm hopeful to have converted those to modules by then.
Create a script to update examples including ensuring that the README has the real values.yaml.