Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a conditional to enable or disable bearer token in auto discovery #686

Conversation

reginaldomoura-jr
Copy link
Contributor

This is to allow users to disable or enable the usage of sa bearer token in auto discovery, this was add on version 1.3.0, but users don't have a option to disable it if this is not needed. Unauthenticated services using Service Account without token or services not behind something like kube-rbac-proxy is returning 400 error.

#580

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

@reginaldomoura-jr
Copy link
Contributor Author

Hi @petewall and @skl,

Can you help me to figure this issue?

We are not using the Service Account Tokens on our /metrics at this moment, and we are not using a proxy in front of this as well. Can we have a way to disable and enable the token path? I'm doing this proposal, on this MR. Please, let me know if I'm missing something.

Our services is getting 400, when auto discovery try to get the metrics.

@petewall
Copy link
Collaborator

Run helm-docs again and I think you'll be set!

@reginaldomoura-jr
Copy link
Contributor Author

Thank You @petewall, I had run helm-docs. Tests is passing now.

@petewall petewall merged commit eacedb9 into grafana:main Aug 16, 2024
16 checks passed
@petewall
Copy link
Collaborator

My plan is to merge a few more and drop version 1.5 either today or Monday.

@reginaldomoura-jr
Copy link
Contributor Author

My plan is to merge a few more and drop version 1.5 either today or Monday.
Thank you! This will help us to update our K8S Monitoring without any impact on metrics being scraped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants