fixup! fixup! Introduce Set type for encoding structured metadata fields

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
grafana · Sep 4, 2024 · 1378b11 · 1378b11
1 parent ba0473d
commit 1378b11
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/pkg/storage/bloom/v1/builder.go b/pkg/storage/bloom/v1/builder.go
@@ -301,10 +301,10 @@ func (mb *MergeBuilder) processNextSeries(
 		bytesAdded += bloom.SourceBytesAdded
 	}
 
-	// TODO(chaudum): Currently we don't extract the indexed fields when building blooms
-	// Instead, just use a placeholder for now.
+	// TODO(chaudum): Use the indexed fields from bloom creation, however,
+	// currently we still build blooms from log lines.
 	fields := NewSet[Field](1)
-	fields.Add("__all__")
+	fields.Add("__line__")
 
 	done, err := builder.AddSeries(*nextInStore, offsets, fields)
 	if err != nil {

diff --git a/pkg/storage/bloom/v1/versioned_builder.go b/pkg/storage/bloom/v1/versioned_builder.go
@@ -79,10 +79,10 @@ func (b *V3Builder) BuildFrom(itr iter.Iterator[SeriesWithBlooms]) (uint32, erro
 			return 0, errors.Wrap(err, "iterating blooms")
 		}
 
-		// TODO(chaudum): Currently we don't extract the indexed fields when building blooms
-		// Instead, just use a placeholder for now.
+		// TODO(chaudum): Use the indexed fields from bloom creation, however,
+		// currently we still build blooms from log lines.
 		fields := NewSet[Field](1)
-		fields.Add("__all__")
+		fields.Add("__line__")
 
 		blockFull, err := b.AddSeries(*at.Series, offsets, fields)
 		if err != nil {