Skip to content

Commit

Permalink
helm: update default terminationGracePeriodSeconds to 4800 (#1257)
Browse files Browse the repository at this point in the history
Users that run Loki using the Helm chart may not modify the value for
terminationGracePeriodSeconds that allows Loki enough time to flush all
of its data. If Loki is forcefully terminated by Kubernetes during a
flush, missing data or an unhealthy ingester in the ring in
microservices mode can occur.

This commit changes the grace period to 4800 seconds, the value used in
the Jsonnet code.
  • Loading branch information
rfratto authored Nov 13, 2019
1 parent c1e84b5 commit 1d3b0be
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion production/helm/loki-stack/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: "v1"
name: loki-stack
version: 0.19.0
version: 0.19.1
appVersion: v0.4.0
kubeVersion: "^1.10.0-0"
description: "Loki: like Prometheus, but for logs."
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: "v1"
name: loki
version: 0.17.1
version: 0.17.2
appVersion: v0.4.0
kubeVersion: "^1.10.0-0"
description: "Loki: like Prometheus, but for logs."
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ serviceAccount:
create: true
name:

terminationGracePeriodSeconds: 30
terminationGracePeriodSeconds: 4800

## Tolerations for pod assignment
## ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
Expand Down

0 comments on commit 1d3b0be

Please sign in to comment.