Add hidden config for bloom builder working directory

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>

pkg/bloombuild/builder/builder.go

@@ -488,7 +488,7 @@ func (b *Builder) loadWorkForGap(
 }
 
 func (b *Builder) writerReaderFunc() (v1.BlockWriter, v1.BlockReader) {
-	dir, err := os.MkdirTemp("", "bloom-block-")
+	dir, err := os.MkdirTemp(b.cfg.WorkingDir, "bloom-block-")
 	if err != nil {
 		panic(err)
 	}

pkg/bloombuild/builder/config.go

@@ -13,13 +13,15 @@ type Config struct {
 	GrpcConfig     grpcclient.Config `yaml:"grpc_config"`
 	PlannerAddress string            `yaml:"planner_address"`
 	BackoffConfig  backoff.Config    `yaml:"backoff_config"`
+	WorkingDir     string            `yaml:"working_directory" doc:"hidden"`
 }
 
 // RegisterFlagsWithPrefix registers flags for the bloom-planner configuration.
 func (cfg *Config) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) {
 	f.StringVar(&cfg.PlannerAddress, prefix+".planner-address", "", "Hostname (and port) of the bloom planner")
 	cfg.GrpcConfig.RegisterFlagsWithPrefix(prefix+".grpc", f)
 	cfg.BackoffConfig.RegisterFlagsWithPrefix(prefix+".backoff", f)
+	f.StringVar(&cfg.WorkingDir, prefix+".working-directory", "", "Working directory to which blocks are temporarily written to. Empty string defaults to the operating system's temp directory.")
 }
 
 func (cfg *Config) Validate() error {

pkg/bloombuild/builder/spec.go

@@ -224,13 +224,15 @@ func (b *LazyBlockBuilderIterator) Next() bool {
 	writer, reader := b.writerReaderFunc()
 	blockBuilder, err := v1.NewBlockBuilder(b.opts, writer)
 	if err != nil {
+		_ = writer.Cleanup()
 		b.err = errors.Wrap(err, "failed to create bloom block builder")
 		return false
 	}
 	_, sourceBytes, err := mergeBuilder.Build(blockBuilder)
 	b.bytesAdded += sourceBytes
 
 	if err != nil {
+		_ = writer.Cleanup()
 		b.err = errors.Wrap(err, "failed to build bloom block")
 		return false
 	}