fixup! fixup! fixup! Apply changes from code review

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
grafana · Sep 5, 2024 · ea8a541 · ea8a541
1 parent 04d3d14
commit ea8a541
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 14 deletions.
diff --git a/pkg/storage/bloom/v1/bloom_builder.go b/pkg/storage/bloom/v1/bloom_builder.go
@@ -46,8 +46,6 @@ func (b *BloomBlockBuilder) Append(bloom *Bloom) (BloomOffset, error) {
 		}
 	}
 
-	// version := b.opts.Schema.version
-
 	b.scratch.Reset()
 	if err := bloom.Encode(b.scratch); err != nil {
 		return BloomOffset{}, errors.Wrap(err, "encoding bloom")

diff --git a/pkg/storage/bloom/v1/builder.go b/pkg/storage/bloom/v1/builder.go
@@ -66,18 +66,6 @@ func (b BlockOptions) Encode(enc *encoding.Encbuf) {
 	enc.PutBE64(b.BlockSize)
 }
 
-// func NewDefaultBlockOptions(maxBlockSizeBytes, maxBloomSizeBytes uint64) BlockOptions {
-// 	opts := NewBlockOptionsFromSchema(Schema{
-// 		version:     DefaultSchemaVersion,
-// 		encoding:    chunkenc.EncNone,
-// 		nGramLength: 0,
-// 		nGramSkip:   0,
-// 	})
-// 	opts.BlockSize = maxBlockSizeBytes
-// 	opts.UnencodedBlockOptions.MaxBloomSizeBytes = maxBloomSizeBytes
-// 	return opts
-// }
-
 func NewBlockOptions(enc chunkenc.Encoding, nGramLength, nGramSkip, maxBlockSizeBytes, maxBloomSizeBytes uint64) BlockOptions {
 	opts := NewBlockOptionsFromSchema(Schema{
 		version:     CurrentSchemaVersion,