Skip to content

Commit

Permalink
fix(blooms): ignores bloom filtering errors in bounded shard query pl…
Browse files Browse the repository at this point in the history
…anning (#13285)
  • Loading branch information
owen-d authored Jun 21, 2024
1 parent eb1cd4c commit ede6941
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions pkg/indexgateway/gateway.go
Original file line number Diff line number Diff line change
Expand Up @@ -465,12 +465,15 @@ func (g *Gateway) boundedShards(
// 2) filter via blooms if enabled
filters := syntax.ExtractLineFilters(p.Plan().AST)
if g.bloomQuerier != nil && len(filters) > 0 {
filtered, err = g.bloomQuerier.FilterChunkRefs(ctx, instanceID, req.From, req.Through, refs, p.Plan())
xs, err := g.bloomQuerier.FilterChunkRefs(ctx, instanceID, req.From, req.Through, refs, p.Plan())
if err != nil {
return err
level.Error(logger).Log("msg", "failed to filter chunk refs", "err", err)
} else {
filtered = xs
}
sp.LogKV(
"stage", "queried bloom gateway",
"err", err,
)
}

Expand Down

0 comments on commit ede6941

Please sign in to comment.