Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different config between doc and code for limits config #1147

Closed
mizeng opened this issue Oct 12, 2019 · 4 comments
Closed

Different config between doc and code for limits config #1147

mizeng opened this issue Oct 12, 2019 · 4 comments
Labels
stale A stale issue or PR that will automatically be closed.

Comments

@mizeng
Copy link
Contributor

mizeng commented Oct 12, 2019

Describe the bug
Seems there're quite a few difference of limits config between config doc and real code.
e.g. https://github.com/grafana/loki/tree/master/docs/configuration#limits_config vs https://github.com/grafana/loki/blob/master/pkg/util/validation/limits.go#L15-L40

Take ** ingestion_rate** as an example, I can not find it in the code at all. Instead, there's one named "ingestion_rate_mb". Do I miss something?

@eminden
Copy link

eminden commented Nov 6, 2019

I hit the same one (ingestion-rate-limit-mb vs ingestion-rate) right now.

@stale
Copy link

stale bot commented Dec 6, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Dec 6, 2019
@pstibrany
Copy link
Member

This seems to have been fixed by #1278

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Dec 9, 2019
@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jan 11, 2020
@stale stale bot closed this as completed Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

No branches or pull requests

3 participants