Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update limits_config to new structure from #948 #1278

Merged
merged 3 commits into from
Nov 20, 2019

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Nov 18, 2019

The limits_config schema in the Loki configuration docs was using the old Cortex object and not the new Loki object.

/cc @sandlis

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small fixes in the text explaining the limits otherwise it LTGM.

docs/configuration/README.md Outdated Show resolved Hide resolved
docs/configuration/README.md Outdated Show resolved Hide resolved
rfratto and others added 2 commits November 19, 2019 08:31
Co-Authored-By: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto merged commit 6d09865 into grafana:master Nov 20, 2019
@rfratto rfratto deleted the update-limits-config-docs branch November 20, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants