fix: Fixes read & backend replicas settings #12828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thorker <th.kerber+github@gmail.com>
|
|
| @@ -23,7 +23,7 @@ spec: | |||
| {{- if eq .Values.deploymentMode "SingleBinary" }} | |||
| replicas: 0 | |||
| {{- else }} | |||
| replicas: {{ .Values.write.replicas }} | |||
| replicas: {{ .Values.backend.replicas }} | |||
There was a problem hiding this comment.
4 lines above this still says if not .Values.write.autoscaling.enabled. Shouldn't that use backend as well?
| @@ -23,7 +23,7 @@ spec: | |||
| {{- if eq .Values.deploymentMode "SingleBinary" }} | |||
| replicas: 0 | |||
| {{- else }} | |||
| replicas: {{ .Values.write.replicas }} | |||
| replicas: {{ .Values.read.replicas }} | |||
production/helm/loki/Chart.yaml
Outdated
| @@ -3,7 +3,7 @@ name: loki | |||
| description: Helm chart for Grafana Loki in simple, scalable mode | |||
| type: application | |||
| appVersion: 3.0.0 | |||
| version: 6.3.4 | |||
| version: 6.3.5 | |||
There was a problem hiding this comment.
The latest version is 6.4 now. Please use 6.4.1. And also please update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md.
There was a problem hiding this comment.
Thought README & CHANGELOG will be generated via CI Pipeline or did I missed sth?
There was a problem hiding this comment.
Not for the Helm charts at the moment so they have to be updated by hand.
Signed-off-by: thorker <th.kerber+github@gmail.com>
# Conflicts: # production/helm/loki/Chart.yaml
Signed-off-by: thorker <th.kerber+github@gmail.com> Signed-off-by: thorker <th.kerber+github@gmail.com>
Signed-off-by: thorker <th.kerber+github@gmail.com> Signed-off-by: thorker <th.kerber+github@gmail.com>
MichelHollands
approved these changes
Apr 30, 2024
shantanualsi
pushed a commit
that referenced
this pull request
May 6, 2024
Signed-off-by: thorker <th.kerber+github@gmail.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
This was referenced May 6, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
Signed-off-by: thorker <th.kerber+github@gmail.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes incorrect configuration of read & backend replicas
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR