Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes read & backend replicas settings #12828

Merged
merged 7 commits into from
Apr 30, 2024
Merged

fix: Fixes read & backend replicas settings #12828

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fac2bac
fix: read & backend replica settings
thorker Apr 30, 2024
352d49d
fix: if condition
thorker Apr 30, 2024
9ba5bc4
Merge branch 'refs/heads/main' into thorker/fix-replicas
thorker Apr 30, 2024
1f94762
chore: updated README
thorker Apr 30, 2024
de33a62
chore: updated CHANGELOG
thorker Apr 30, 2024
f7967a8
Merge branch 'main' into thorker/fix-replicas
thorker Apr 30, 2024
2438fa6
Merge branch 'main' into thorker/fix-replicas
MichelHollands Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion production/helm/loki/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: loki
description: Helm chart for Grafana Loki in simple, scalable mode
type: application
appVersion: 3.0.0
version: 6.3.4
version: 6.3.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version is 6.4 now. Please use 6.4.1. And also please update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought README & CHANGELOG will be generated via CI Pipeline or did I missed sth?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for the Helm charts at the moment so they have to be updated by hand.

home: https://grafana.github.io/helm-charts
sources:
- https://github.com/grafana/loki
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/templates/backend/statefulset-backend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
{{- if eq .Values.deploymentMode "SingleBinary" }}
replicas: 0
{{- else }}
replicas: {{ .Values.write.replicas }}
replicas: {{ .Values.backend.replicas }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 lines above this still says if not .Values.write.autoscaling.enabled. Shouldn't that use backend as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

{{- end }}
{{- end }}
podManagementPolicy: {{ .Values.backend.podManagementPolicy }}
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/templates/read/statefulset-read.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
{{- if eq .Values.deploymentMode "SingleBinary" }}
replicas: 0
{{- else }}
replicas: {{ .Values.write.replicas }}
replicas: {{ .Values.read.replicas }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

{{- end }}
{{- end }}
podManagementPolicy: {{ .Values.read.podManagementPolicy }}
Expand Down
Loading