Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Add support for managed GCP WorkloadIdentity #14752

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Nov 4, 2024

What this PR does / why we need it:
Adds support for managed GCP WorkloadIdentity auth on OpenShift Cluster 4.17+

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass

operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
operator/internal/handlers/internal/storage/secrets.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code POV this looks good still have to actually test it

Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅ lgtm
grafik

@periklis periklis merged commit 7635a5c into grafana:main Nov 8, 2024
66 checks passed
periklis added a commit to periklis/loki that referenced this pull request Nov 18, 2024
periklis added a commit to periklis/loki that referenced this pull request Nov 18, 2024
openshift-merge-bot bot added a commit to openshift/loki that referenced this pull request Nov 25, 2024
openshift-merge-bot bot added a commit to openshift/loki that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants