Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-6.1] Backport PR grafana/loki#14752 #395

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[release-6.1] Backport PR grafana/loki#14752 #395

merged 1 commit into from
Nov 27, 2024

Conversation

periklis
Copy link

@periklis periklis commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

Add support for managed GCP WorkloadIdentity to release-6.1.

Refs: LOG-6158

@openshift-ci openshift-ci bot requested review from jcantrill and syedriko November 18, 2024 12:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@periklis
Copy link
Author

/hold Until @xperimental and/or @JoaoBraveCoding approves the backport

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@JoaoBraveCoding
Copy link

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
JoaoBraveCoding
JoaoBraveCoding approved these changes Nov 25, 2024
View reviewed changes
Copy link

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoaoBraveCoding
Copy link

/retest-required

@JoaoBraveCoding
Copy link

/test test-operator

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 27, 2024

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fa492a8 into openshift:release-6.1 Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding approved these changes

@xperimental xperimental Awaiting requested review from xperimental xperimental is a code owner

@jcantrill jcantrill Awaiting requested review from jcantrill

@syedriko syedriko Awaiting requested review from syedriko

Assignees

@JoaoBraveCoding JoaoBraveCoding

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@periklis @JoaoBraveCoding