Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide logcli docker image #1751

Closed
varac opened this issue Feb 27, 2020 · 4 comments · Fixed by #2561
Closed

Provide logcli docker image #1751

varac opened this issue Feb 27, 2020 · 4 comments · Fixed by #2561
Labels
component/packaging good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@varac
Copy link

varac commented Feb 27, 2020

Is your feature request related to a problem? Please describe.

I'd like to install logcli as a docker container, because installing binaries on some OS (i.e. k3os/coreos) is discouraged in favor of container installations.
However. the official grafana/logcli is lacking tags and is therefore not usabale. I also don't like to install untrusted images from docker hub.

Describe the solution you'd like

Please publish latest logcli docker images, or include logcli inside the grafana/loki image.

Describe alternatives you've considered

  • Maintaining your own image, which comes with extra overhead for a lot of users
  • Installing the binary as descibed in the docs.

Thanks !
@cyriltovena cyriltovena added component/packaging keepalive An issue or PR that will be kept alive and never marked as stale. labels Feb 28, 2020
@slim-bean slim-bean added help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! labels Apr 2, 2020
@cyriltovena
Copy link
Contributor

If someone wants to do this I've started a branch
https://github.com/cyriltovena/loki/tree/logci-docker

We just need to hook the CI.

@tharun208
Copy link
Contributor

I like to work on this

@slim-bean
Copy link
Collaborator

@tharun208 let us know if there is anything we can do to help!

@tharun208 tharun208 mentioned this issue Aug 27, 2020
Merged
2 tasks
@tharun208
Copy link
Contributor

@slim-bean raised a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/packaging good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added logcli docker image tharun208/loki
5 participants
@varac @cyriltovena @owen-d @slim-bean @tharun208