Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: conflicting schema version recommendation #1778

Closed
candlerb opened this issue Mar 6, 2020 · 1 comment · Fixed by #1781
Closed

Doc: conflicting schema version recommendation #1778

candlerb opened this issue Mar 6, 2020 · 1 comment · Fixed by #1781

Comments

@candlerb
Copy link
Contributor

candlerb commented Mar 6, 2020

Describe the bug
The documentation is inconsistent as to whether new installations should use v10 or v11 schema.

To Reproduce
At https://github.com/grafana/loki/blob/master/docs/architecture.md it says:

The current schema recommendation is the v10 schema.

But in the sample loki configuration at https://github.com/grafana/loki/blob/master/cmd/loki/loki-local-config.yaml it says

schema: v11

Expected behavior
If the current schema recommendation is the v10 schema, then I'd expect the sample config to use the v10 schema too.

Environment:
N/A

Screenshots, Promtail config, or terminal output
N/A

@slim-bean
Copy link
Collaborator

hey @candlerb thanks for bringing this up.

v11 is the recommended schema, would you be interested in a PR to fix the docs?

candlerb added a commit to candlerb/loki that referenced this issue Mar 6, 2020
Fixes grafana#1778

Signed-off-by: Brian Candler <b.candler@pobox.com>
slim-bean pushed a commit that referenced this issue Mar 6, 2020
Fixes #1778

Signed-off-by: Brian Candler <b.candler@pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants