-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to promtail 1.4.1 fail #1921
Comments
So it works fine with 1.15 kubernetes but it seems to think there is a pipe when running in kubernetes 1.16.7. hum. |
Any chance you're running the container with |
@cyriltovena Thanks by the response, I'm not sure about that, i'm using the default config in the helm chart. just Thanks Juanma |
We had another instance of the same behavior by someone in public slack, different setup, was actually maing their own image, however the output is the same. I'm thinking that we should remove the code to try to detect if someone is piping to promtail, checking if stdin is a character device isn't proving to be reliable enough and troubleshooting why it's going wrong is extremely difficult. I think i'm going to suggest we remove the auto detect code and instead add @cyriltovena WDYT? |
Yep will do in the meantime use 1.4.0
Le ven. 10 avr. 2020 à 21:19, Ed Welch <notifications@github.com> a écrit :
… We had another instance of the same behavior by someone in public slack,
different setup, was actually maing their own image, however the output is
the same.
I'm thinking that we should remove the code to try to detect if someone is
piping to promtail, checking if stdin is a character device isn't proving
to be reliable enough and troubleshooting why it's going wrong is extremely
difficult.
I think i'm going to suggest we remove the auto detect code and instead
add --stdin as a flag if someone would like promtail to read from stdin.
@cyriltovena <https://github.com/cyriltovena> WDYT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1921 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIBF3L3OI5XCOMXORY3KLTRL7ARPANCNFSM4MEQEBOA>
.
|
This seems to causes issue on some environment so let's use a flag instead. Fixes grafana#1921 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
This seems to causes issue on some environment so let's use a flag instead. Fixes #1921 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
I have same issue.
kubernetes v1.16.2 |
Same CrashloopBackoff behavior here with promtail 1.4.1 and kubernetes 1.14.3. promtail 1.4.0 worked. $ helm upgrade --install loki loki/loki-stack |
Fixed in: |
Describe the bug
When i try to upgrade using loki-stack helm chart to the latest version , promtail doesn't start. The pod will be stay in CrashLoopBackOff state.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Upgrate promtail to latest version 1.4.1
Environment:
Screenshots, Promtail config, or terminal output
when i get the logs of the pod that is crashing
If i change the docker image to 1.4.0 works fine.
I tested in a docker cluster in my laptop using k8s 1.5.5 and works fine.
The text was updated successfully, but these errors were encountered: