Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split series API in frontend #2106

Closed
owen-d opened this issue May 21, 2020 · 4 comments
Closed

Split series API in frontend #2106

owen-d opened this issue May 21, 2020 · 4 comments
Assignees
@adityacs

Comments

@owen-d
Copy link
Member

owen-d commented May 21, 2020 •
edited
Loading

Split the /series API calls by time in the frontend for long-dated requests. We could also shard this against the shard_factor if the schema supports it for further benefits.

/cc @cyriltovena
@owen-d
Copy link
Member Author

owen-d commented May 26, 2020

We'll probably need a refactor to the roundtripper (https://github.com/grafana/loki/blob/master/pkg/querier/queryrange/roundtrip.go#L78) to also handle the series API. This in turn can also be implemented with the time-splitting middleware (https://github.com/grafana/loki/blob/master/pkg/querier/queryrange/split_by_interval.go).

@adityacs you seem pretty interested, would you like me to assign this to you?

@adityacs
Copy link
Contributor

@owen-d Yeah, I would like to work on this. Kindly assign it to me.

@adityacs
Copy link
Contributor

@owen-d I will be closing this

@adityacs
Copy link
Contributor

Fixed in #2123

cyriltovena pushed a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
@pstibrany
goimports -local github.com/cortexproject/cortex -w pkg/ cmd/ tools/ (g…
a633c1c 
…rafana#2106)

* Verify that files have correct order of imports.

goimports -local github.com/cortexproject/cortex does the trick.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

* goimports -local github.com/cortexproject/cortex -w pkg/ cmd/ tools/

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

* Rerun make protos.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

* Fixed import
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

* Rerun make protos for ruler
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityacs adityacs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adityacs @owen-d