Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki 1.5.0: The "loki-loki-stack" ConfigMap is not created for "loki-stack-datasource.yaml" #2195

Closed
k8s42 opened this issue Jun 8, 2020 · 4 comments · Fixed by #2197
Closed

Comments

@k8s42
Copy link

k8s42 commented Jun 8, 2020

Describe the bug
I deployed the Loki Stack (stable) using Helm 3 and Loki 1.5.0 was deployed but no ConfigMap was created for the "loki-stack-datasource.yaml" file.

To Reproduce
Steps to reproduce the behavior:

  1. Add repo:
    helm3 repo add loki https://grafana.github.io/loki/charts
  2. Deploy Loki Stack using Helm 3:
    helm3 --install --name=loki loki/loki-stack
  3. List ConfigMaps in Loki namespace:
    kubectl get configmaps -n loki
    NAME DATA AGE
    loki-loki-stack-test 1 6m19s
    loki-promtail 1 6m19s

Expected behavior
The "loki-loki-stack" should've been created for "loki-stack-datasource.yaml".

Environment:

  • Infrastructure: Kubernetes v1.15.10
  • Deployment tool: Helm3
  • Loki: v1.5.0

Screenshots, Promtail config, or terminal output
This was not an issue in Loki 1.4.1.

@cyriltovena
Copy link
Contributor

is this a duplicate of #2186 ? Can you confirm ?

cyriltovena added a commit to cyriltovena/loki that referenced this issue Jun 8, 2020
I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment.

Fixes grafana#2186
Fixes grafana#2195

Now regarding grafana#2086 it seems pretty easy to use `.Values.grafana.sidecar.datasources.enabled` if you don't want any datasources.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@k8s42
Copy link
Author

k8s42 commented Jun 10, 2020

is this a duplicate of #2186 ? Can you confirm ?

I do not fully understand the context of #2186. My issue is that I used to get a configmap called "loki-loki-stack" in versions lower than 1.5.0 just about a few weeks ago. In 1.5.0, the configmap "loki-loki-stack" no longer gets created.

@cyriltovena
Copy link
Contributor

Yes it's exactly that.

@k8s42
Copy link
Author

k8s42 commented Jun 10, 2020

To give you a clear context on my issue:

My promtail ships logs to Loki (hosted in a different cluster). So, to get things working this way, I'd add following to these YAML files:

promtail.yaml:
url: http://loki.mydomain.com/loki/api/v1/push

loki-stack-datasource.yaml
url: http://loki.mydomain.com

Since I don't have a configmap for loki-stack-datasource.yaml in 1.5.0, I don't have url: http://loki.mydomain.com specified for promtail to send logs to.

Is there a different way to accomplish this now?

cyriltovena added a commit that referenced this issue Jun 22, 2020
I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment.

Fixes #2186
Fixes #2195

Now regarding #2086 it seems pretty easy to use `.Values.grafana.sidecar.datasources.enabled` if you don't want any datasources.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment.

Fixes grafana#2186
Fixes grafana#2195

Now regarding grafana#2086 it seems pretty easy to use `.Values.grafana.sidecar.datasources.enabled` if you don't want any datasources.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants