Tanka getting started errors with: must define boltdb_shipper_shared_store

[chancez]

Describe the bug
Tanka getting started example fails on boltdb-shipper config option, even when not using boltdb-shipper:

evaluating jsonnet: RUNTIME ERROR: must define boltdb_shipper_shared_store

Config:

local gateway = import 'loki/gateway.libsonnet';
local loki = import 'loki/loki.libsonnet';

loki + gateway {
  _config+:: {
    namespace: 'loki-production',
    htpasswd_contents: 'loki:$apr1$H4yGiGNg$ssl5/NymaGFRUvxIV1Nyr.',

    // boltdb_shipper_shared_store: 'ignore',

    // S3 variables remove if not using aws
    storage_backend: 's3,dynamodb',
    s3_access_key: 'key',
    s3_secret_access_key: 'secret access key',
    s3_address: 'url',
    s3_bucket_name: 'loki-test',
    dynamodb_region: 'region',

    replication_factor: 3,
    consul_replicas: 1,
  },
}

To Reproduce
Steps to reproduce the behavior:

1. Follow instructions at https://github.com/grafana/loki/blob/master/docs/sources/installation/tanka.md
2. tk show environments/loki

Expected behavior

I expect no errors if boldb shipper isn't used.

Environment:

• Infrastructure: laptop
• Deployment tool: tanka

Screenshots, Promtail config, or terminal output

Full error:

~/p/l/tanka-loki(⎈ |production-2457-us-west-2:default) czibolski ❯❯❯ tk show environments/loki                                                                                                                                                                                                                                                                                                                               ⏎master ✭ ◼
evaluating jsonnet: RUNTIME ERROR: must define boltdb_shipper_shared_store
	/Users/czibolski/projects/loki/tanka-loki/vendor/loki/boltdb_shipper.libsonnet:14:34-81	object <anonymous>
	/Users/czibolski/projects/loki/tanka-loki/vendor/loki/boltdb_shipper.libsonnet:23:25-62	object <anonymous>
	/Users/czibolski/projects/loki/tanka-loki/vendor/loki/config.libsonnet:360:28-56	builtin function <toString>
	/Users/czibolski/projects/loki/tanka-loki/vendor/loki/config.libsonnet:360:20-57	object <anonymous>
	During manifestation

[sandeepsukhani]

You need to explicitly set using_boltdb_shipper to false when not using boltdb shipper, which defaults to true now.
We will see if we can improve the user experience or add more info about it.

[chancez]

@sandeepsukhani Ah that works, I didn't notice that option. It would probably be nice take care of setting using_boltdb_shipper based on if it's being used in the schema config, but not a huge deal.

[CandiedCode]

@slim-bean since I have a PR on this already, any chance I can get a review? It also has a fix for a failing helm test.

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.