-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does Loki docker driver respect max-file
and max-size
from json-driver?
#3046
Comments
It will use the default. |
Thanks, @cyriltovena ! How about such addition in docs?
|
Sounds good ! |
Clarify docker-driver configuration about `max-file` and `max-size` default values. Fixes grafana#3046
Clarify docker-driver configuration about `max-file` and `max-size` default values. Fixes #3046
Previously it would record a `Memcached.Get` operation with a nested `Memcached.GetMulti`; since they are in one-to-one correspondance this is pointless. Skip the outer data collection for the non-batched case, and rename the batched one to `Memcached.GetBatched` which is more descriptive. These names are used for metric labels and for tracing span names. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
I have a docker daemon with the default json logging config:
Then I run a container that sends logs to Loki :
I don't specify
max-file
andmax-size
options.What will be actual values of
max-file
andmax-size
?Will Loki use it's defaults (
max-file=1
,max-size=-1
per docs) or it will borrow these options from json log driver?It would be great to clarify in docs.
Thanks!
The text was updated successfully, but these errors were encountered: