Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: Switch/upgrade github.com/satori/go.uuid to github.com/gofrs/uuid #3742

Closed
marefr opened this issue May 18, 2021 · 0 comments · Fixed by #3743
Closed

Security: Switch/upgrade github.com/satori/go.uuid to github.com/gofrs/uuid #3742

marefr opened this issue May 18, 2021 · 0 comments · Fixed by #3743

Comments

@marefr
Copy link
Contributor

marefr commented May 18, 2021

Describe the bug
Grafana backend is dependent on loki Go module and by that gets the github.com/satori/go.uuid dependency. github.com/satori/go.uuid is deprecated according to satori/go.uuid#84 and it's suggested to use github.com/gofrs/uuid instead which is properly maintained. github.com/gofrs/uuid should also have fixed the WS-2018-0594 vulnerability.

Looking at go.mod it seems loki has looked the version to 1.2.0:

loki/go.mod

Lines 93 to 94 in 89bdc9c

// >v1.2.0 has some conflict with prometheus/alertmanager. Hence prevent the upgrade till it's fixed.
replace github.com/satori/go.uuid => github.com/satori/go.uuid v1.2.0

However, there's no higher versions available of github.com/satori/go.uuid. Only with github.com/gofrs/uuid. And looking at prometheus/alertmanager they currently uses the latter, see https://github.com/prometheus/alertmanager/blob/7301451eb94d2081fb740abf29755861dd122c65/go.mod#L15

Is there something that can be done here or are you blocked by other dependencies?
cyriltovena added a commit to cyriltovena/loki that referenced this issue May 18, 2021
@cyriltovena
Replace satori.uuid with gofrs/uuid
cef702e 
Fixes grafana#3742

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena mentioned this issue May 18, 2021
Merged
cyriltovena added a commit that referenced this issue May 20, 2021
@cyriltovena
Replace satori.uuid with gofrs/uuid (#3743)
15d417e 
* Replace satori.uuid with gofrs/uuid

Fixes #3742

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Fix new import.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace satori.uuid with gofrs/uuid cyriltovena/loki
1 participant
@marefr