Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the validity setting of 1h from the chunks cache as chunks are immutable and expiring them based on time is wasteful #4922

Closed
Tracked by #4921
slim-bean opened this issue Dec 13, 2021 · 0 comments
Closed
Tracked by #4921

Remove the validity setting of 1h from the chunks cache as chunks are immutable and expiring them based on time is wasteful #4922

slim-bean opened this issue Dec 13, 2021 · 0 comments

Comments

@slim-bean
Copy link
Collaborator

slim-bean commented Dec 13, 2021 •
edited
Loading

See #4921 for more info, but we should remove the validity setting of 1h we applied in 2.4 for the chunks cache because it doesn't reduce memory usage and instead leads to valid chunks being ignore when querying the cache. Chunks are immutable so it doesn't make sense to not return them if they are present in the cache.
@slim-bean slim-bean mentioned this issue Dec 13, 2021
Closed
2 tasks
chaudum added a commit that referenced this issue Jan 14, 2022
@chaudum
Remove validity from FIFO cache
088c506 
We can remove the validity setting of 1h in 2.4 for the
chunks cache because it doesn't reduce memory usage and instead leads to
valid chunks being ignore when querying the cache. Chunks are immutable
so it doesn't make sense to not return them if they are present in the
cache.

Closes #4922

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum added a commit that referenced this issue Jan 17, 2022
@chaudum
Remove validity from FIFO cache
62e2ffd 
We can remove the validity setting of 1h in 2.4 for the
chunks cache because it doesn't reduce memory usage and instead leads to
valid chunks being ignore when querying the cache. Chunks are immutable
so it doesn't make sense to not return them if they are present in the
cache.

Closes #4922

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum added a commit that referenced this issue Jan 18, 2022
@chaudum
Remove validity from FIFO cache
2dbec77 
We can remove the validity setting of 1h in 2.4 for the
chunks cache because it doesn't reduce memory usage and instead leads to
valid chunks being ignore when querying the cache. Chunks are immutable
so it doesn't make sense to not return them if they are present in the
cache.

Closes #4922

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum added a commit that referenced this issue Jan 24, 2022
@chaudum
Remove validity from FIFO cache
22ae177 
We can remove the validity setting of 1h in 2.4 for the
chunks cache because it doesn't reduce memory usage and instead leads to
valid chunks being ignore when querying the cache. Chunks are immutable
so it doesn't make sense to not return them if they are present in the
cache.

Closes #4922

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum added a commit that referenced this issue Jan 29, 2022
@chaudum
Remove validity from FIFO cache
625b7b3 
We can remove the validity setting of 1h in 2.4 for the
chunks cache because it doesn't reduce memory usage and instead leads to
valid chunks being ignore when querying the cache. Chunks are immutable
so it doesn't make sense to not return them if they are present in the
cache.

Closes #4922

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@owen-d owen-d closed this as completed in 57b384d Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slim-bean