You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
With Loki 2.8.2 simple scalable mode ( read and write targets ) per-tenant timeout is configured using runtime configuration. But Loki shows a warn per-tenant timeout not configured, using default engine timeout (\"5m0s\"). This behavior will change in the next major to always use the default per-tenant timeout (\"5m\").
level=warn ts=2023-06-26T14:24:12.394946274Z caller=loki.go:286 msg="per-tenant timeout not configured, using default engine timeout ("5m0s"). This behavior will change in the next major to always use the default per-tenant timeout ("5m")."
Expected behavior
Since query_timeout is already defined in runtime configuration this line of log is not expected to appear. Either Loki logging system is false or runtime configuration is not respected.
Environment:
gke
kustomize
Screenshots, Promtail config, or terminal output
The text was updated successfully, but these errors were encountered:
I've investigated this bug for the last couple of days. I can confirm that this is just an issue with the log wording.
The per-tenant Overrides are applied as expected, and the logic behind the warning only pertains to the global Limits Config and not the per-tenant one.
I'll open a PR soon to suggest a better wording for that warning message.
**What this PR does / why we need it**:
This PR fixes the warning messages that are logged in relation to the
timeouts migration.
The messages reference the per-tenant config, but the config in question
in the `AdjustForTimeoutsMigration` function is the global
`limits_config`. This is a source of confusion for users.
**Which issue(s) this PR fixes**:
Fixes#9801
Describe the bug
With Loki 2.8.2 simple scalable mode ( read and write targets ) per-tenant timeout is configured using runtime configuration. But Loki shows a warn
per-tenant timeout not configured, using default engine timeout (\"5m0s\"). This behavior will change in the next major to always use the default per-tenant timeout (\"5m\").
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Since
query_timeout
is already defined in runtime configuration this line of log is not expected to appear. Either Loki logging system is false or runtime configuration is not respected.Environment:
Screenshots, Promtail config, or terminal output
The text was updated successfully, but these errors were encountered: