Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1024

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Update README.md #1024

merged 1 commit into from
Sep 18, 2019

Conversation

oddlittlebird
Copy link
Contributor

Minor grammar and consistency edits.

Note: There is inconsistent capitalization of Promtail/promtail. If you let me know which is correct, then I will update this topic as well as the Grafana Style Guide (in progress).

Minor grammar and consistency edits.

Note: There is inconsistent capitalization of Promtail/promtail. If you let me know which is correct, then I will update this topic as well as the Grafana Style Guide (in progress).
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

w/r/t Promtail, my opinion would be to either capitalize it like a proper noun when referring to the software and to use "promtail" to refer to the binary. I think there should be an issue to discuss this, though.

@rfratto rfratto merged commit 717e49e into grafana:master Sep 18, 2019
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants