Bloom Client #10697
Merged
Bloom Client #10697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
chaudum
reviewed
Sep 26, 2023
…files Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
vlad-diachenko
commented
Sep 29, 2023
| func NewShipper(periodicConfigs []config.PeriodConfig, storageConfig storage.Config, clientMetrics storage.ClientMetrics) (*bloomShipper, error) { | ||
| periodicObjectClients := make(map[config.DayTime]client.ObjectClient) | ||
| for _, periodicConfig := range periodicConfigs { | ||
| objectClient, err := storage.NewObjectClient(periodicConfig.ObjectType, storageConfig, clientMetrics) |
There was a problem hiding this comment.
must be prefixedObjectClient . see: tsdb.shared-store-key-prefix
There was a problem hiding this comment.
currently, it's not possible to use prefixedObjectClient outside of package storage.
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
vlad-diachenko
changed the title
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
… on top of the client Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
owen-d
approved these changes
Oct 4, 2023
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
…to vlad.diachenko/bloom_shipper
…ed block file name pattern to make entire object prefix more unique. Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Implemented BloomClient that allows : 1. fetch all meta.json files that satisfy the search criteria 2. upload meta.json 3. delete meta.json 4. fetch bloom blocks in bulk 5. upload bloom blocks in bulk 6. delete bloom blocks in bulk Bloom shipper was extracted to a separate PR grafana#10806 --------- Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented BloomClient that allows :
Bloom shipper was extracted to a separate PR #10806