Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(fluent-bit): add missing namespace #1077

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Conversation

daixiang0
Copy link
Contributor

Signed-off-by: Xiang Dai 764524258@qq.com

Signed-off-by: Xiang Dai <764524258@qq.com>
@daixiang0
Copy link
Contributor Author

@rfratto mind have a look?

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This mostly LGTM but I want to clarify the paragraph you added.

production/helm/fluent-bit/README.md Outdated Show resolved Hide resolved
Signed-off-by: Xiang Dai <764524258@qq.com>
@rfratto
Copy link
Member

rfratto commented Oct 14, 2019

@daixiang0 I can merge this as soon as the merge conflict is resolved.

@daixiang0
Copy link
Contributor Author

@rfratto done.

@rfratto rfratto merged commit 81f9786 into grafana:master Oct 15, 2019
@daixiang0 daixiang0 deleted the add-namespace branch October 16, 2019 01:56
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
* doc(fluent-bit): add missing namespace

Signed-off-by: Xiang Dai <764524258@qq.com>

* fix a nit

Signed-off-by: Xiang Dai <764524258@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants