Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update stages README with the docker and cri stages #1094

Merged
merged 1 commit into from
Oct 1, 2019
Merged

docs: update stages README with the docker and cri stages #1094

merged 1 commit into from
Oct 1, 2019

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Oct 1, 2019

The newly documented docker and cri stages need to be included in the stages/README.md file as well.

@rfratto rfratto requested a review from slim-bean October 1, 2019 13:43
cyriltovena
cyriltovena approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto merged commit 57e7a1c into grafana:master Oct 1, 2019
@rfratto rfratto deleted the update-stages-readme branch November 19, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@slim-bean slim-bean Awaiting requested review from slim-bean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfratto @cyriltovena