Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo fixed] in CHANGELOG.md #11075

Closed
wants to merge 2 commits into from
Closed

[Typo fixed] in CHANGELOG.md #11075

wants to merge 2 commits into from

Conversation

khalid586
Copy link

What this PR does / why we need it:

Fixes Typo

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory.

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2023

CLA assistant check
All committers have signed the CLA.

@JStickler
Copy link
Contributor

@khalid586 Tagging five different people to review a non-urgent typo is unnecessary. If you're doing Hacktoberfest, the goal is to make meaningful contributions to a project, not to make additional work for maintainers.

Your branch is out of date.

@JStickler
Copy link
Contributor

Yes, I saw that. I'm still trying to decide if I'm going to close this PR and create a "spam" label for it.

@khalid586
Copy link
Author

Yes, I saw that. I'm still trying to decide if I'm going to close this PR and create a "spam" label for it.

why would it be a spam?

@khalid586
Copy link
Author

If a PR is not necessary then it should be closed , it should not be unchecked.

@khalid586 khalid586 closed this Oct 31, 2023
@JStickler
Copy link
Contributor

Because you may not have read the rules when you signed up for Hacktoberfest, but I've done the event for several years.
Spammy

@khalid586
Copy link
Author

khalid586 commented Oct 31, 2023

Because you may not have read the rules when you signed up for Hacktoberfest, but I've done the event for several years. Spammy

I have read the rules but I think you didn't read my question properly. I asked why would it be a spam? I just corrected a mistake and generally these kinds of mistakes are hard to correct because generally nobody has that much time to go through the files/ whole project to fix such trivial errors thus they go unchecked. I just wanted to get my PR reviewed. Merge it or close it. How can you say it a spam PR? Help me understand. @JStickler

And this PR wasn't for hacktoberfest. I don't even know if this repo will be counted or not .

@JStickler
Copy link
Contributor

@khalid586 Your GitHub profile says you're a Hacktoberfest participant. If this PR wasn't for Hacktoberfest, then why did you feel the need to tag five different people rather than waiting for a maintainer to review it when they had time?

Fixing a typo in the code, or a configuration parameter, or in a code example, or in the published docs is helpful because those typos might confuse users or prevent them from being able to use the software successfully.
Fixing a typo while you're submitting a PR for a bug fix or new feature is helpful, because you're cleaning up the code or docs while you're doing other, meaningful work.
Finding a typo in content that doesn't prevent users from being able to use the software, on the last day of Hacktoberfest, and then tagging five different maintainers because you want credit for another PR before Hacktoberfest is over? I would consider that spam.

As I said before, the spirit of Hactoberfest is to encourage people to make meaningful contributions to open source. In past years maintainers have been flooded with XS pull requests that did not provide a great deal of value to their projects, but took up a lot of their time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants