Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtail: fix high CPU usage on large kubernetes clusters. #1118

Merged
merged 3 commits into from
Jul 3, 2020
Merged

promtail: fix high CPU usage on large kubernetes clusters. #1118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6575664
promtail: add api-level node filter for kubernetes discovery
shuttie Jul 3, 2020
e9cb1b9
Merge branch 'master' of https://github.com/grafana/loki
shuttie Jul 3, 2020
970bc9c
promtail: fix hardcoded host value in k8s node filter
shuttie Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions pkg/promtail/targets/filetargetmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/prometheus/common/model"
"github.com/prometheus/prometheus/discovery"
sd_config "github.com/prometheus/prometheus/discovery/config"
"github.com/prometheus/prometheus/discovery/kubernetes"
"github.com/prometheus/prometheus/discovery/targetgroup"
"github.com/prometheus/prometheus/pkg/labels"
"github.com/prometheus/prometheus/pkg/relabel"
Expand All @@ -26,8 +27,9 @@ import (
)

const (
pathLabel = "__path__"
hostLabel = "__host__"
pathLabel = "__path__"
hostLabel = "__host__"
kubernetesPodNodeField = "spec.nodeName"
)

var (
Expand Down Expand Up @@ -121,6 +123,18 @@ func NewFileTargetManager(
}
}

// Add an additional api-level node filtering, so we only fetch pod metadata for
// all the pods from the current node. Without this filtering we will have to
// download metadata for all pods running on a cluster, which may be a long operation.
for _, kube := range cfg.ServiceDiscoveryConfig.KubernetesSDConfigs {
if kube.Role == kubernetes.RolePod {
selector := fmt.Sprintf("%s=%s", kubernetesPodNodeField, hostname)
kube.Selectors = []kubernetes.SelectorConfig{
{Role: kubernetes.RolePod, Field: selector},
}
}
}

s := &targetSyncer{
log: logger,
positions: positions,
Expand Down