Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish loki-canary binaries on release #1121

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Publish loki-canary binaries on release #1121

merged 1 commit into from
Oct 9, 2019

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Oct 5, 2019 •
edited
Loading

What this PR does / why we need it:

To my understanding of the release automation, this 1-line change should be enough to publish loki-canary binaries on release.

Which issue(s) this PR fixes:
Fixes #1059

Checklist

  • Documentation added
  • Tests updated

slim-bean
slim-bean approved these changes Oct 9, 2019
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit d3867cf into grafana:master Oct 9, 2019
@pracucci pracucci deleted the publish-loki-canary-binaries branch October 10, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loki Canary binary not included in release binaries
2 participants
@pracucci @slim-bean