promtail: initialize extracted map with initial labels #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pracucci This is very nice approach. This idea didn't occur to me 😁. Thank you. |
|
LGTM with one comment: could you update the docs to note that the extracted map is pre-populated with existing labels? |
pracucci
force-pushed
the
allow-stages-to-operate-on-initial-labels-too
branch
from
862957e
to
9113633
Compare
|
Thanks @rfratto for your feedback. May you check it again, please? Any feedback on how to clarify it is very welcome 🙏 |
rfratto
reviewed
Oct 9, 2019
pracucci
force-pushed
the
allow-stages-to-operate-on-initial-labels-too
branch
from
9113633
to
bd63a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Initial labels (populated before the pipeline stages run) are unaccessible from the pipeline stages, thus it's not possible to operate on them (ie.
filenameinitial label). The idea proposed in this PR is to initially populate theextractedmap with the initial labels.Which issue(s) this PR fixes:
Fixes #775
Special notes for your reviewer:
Checklist