-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Add a custom metric that collects Lokistacks requiring a schema upgrade #11513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivy scan found the following vulnerabilities:
|
btaani
changed the title
operator: Add a custom metric that collects Loki stacks requiring a schema upgrade
operator: Add a custom metric that collects Lokistacks requiring a schema upgrade
Jan 10, 2024
periklis
reviewed
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Periklis Tsirakidis <periklis@nefeli.eu>
xperimental
reviewed
Jan 16, 2024
operator/internal/manifests/internal/alerts/prometheus-alerts.yaml
Outdated
Show resolved
Hide resolved
operator/internal/manifests/internal/alerts/prometheus-alerts.yaml
Outdated
Show resolved
Hide resolved
…yaml Co-authored-by: Robert Jacob <xperimental@solidproject.de>
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
…yaml Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis
approved these changes
Jan 22, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…hema upgrade (grafana#11513) Co-authored-by: Robert Jacob <rojacob@redhat.com> Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a custom metric that collects Lokistacks that require a storage schema upgrade, as well as a Prometheus alert that gets shown in the console whenever it's triggered
Sample notifications pane from the console:
Which issue(s) this PR fixes:
Fixes LOG-4804 (piggybacking on [#11158]
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR