Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tracing integration to profiling. #11633

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

cyriltovena
Copy link
Contributor

@cyriltovena cyriltovena commented Jan 10, 2024

What this PR does / why we need it:

Same as grafana/tempo#3276 this adds profiling integration to tracing instrumentation allowing to get profile for a single request removing the noise of everything else.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Thanks me later.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

cc @poyzannur we talked about this for compaction to get profiling per run, all you need is a root span per run !

@cyriltovena cyriltovena requested a review from a team as a code owner January 10, 2024 12:58
Copy link
Contributor

Trivy scan found the following vulnerabilities:

  • HIGH, Target: docker.io/grafana/loki:main-24fa648 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libcrypto3 v3.1.3-r0. Fixed in v3.1.4-r0
  • HIGH, Target: docker.io/grafana/loki:main-24fa648 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libssl3 v3.1.3-r0. Fixed in v3.1.4-r0
    \nTo see more details on these vulnerabilities, and how/where to fix them, please run docker build -t grafana/loki:main-24fa648 -f cmd/loki/Dockerfile .
    trivy i grafana/loki:main-24fa648 on your branch. If these were not introduced by your PR, please considering fixing them in via a subsequent PR. Thanks!

Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaudum chaudum merged commit 5517eaa into grafana:main Jan 12, 2024
9 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Same as grafana/tempo#3276 this adds profiling
integration to tracing instrumentation allowing to get profile for a
single request removing the noise of everything else.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants