Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ciliumnetworkpolicy for world egress for table-manager #12143

Merged
merged 6 commits into from
Mar 7, 2024
Merged

feat: add ciliumnetworkpolicy for world egress for table-manager #12143

merged 6 commits into from
Mar 7, 2024

Conversation

QuantumEnigmaa
Copy link
Contributor

What this PR does / why we need it:

This PR adds a CiliumNetworkPolicy with world egress for the table-manager component if it's enabled/

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@QuantumEnigmaa QuantumEnigmaa requested a review from a team as a code owner March 6, 2024 16:50
@QuantumEnigmaa
Copy link
Contributor Author

@MichelHollands it's me again ! 👋
We noticed that if enabled, table-manager needed world egress access to work, hence this PR

MichelHollands
MichelHollands approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelHollands MichelHollands merged commit 336c909 into grafana:main Mar 7, 2024
13 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 27, 2024
Closed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@QuantumEnigmaa @MichelHollands @rhnasc
feat: add ciliumnetworkpolicy for world egress for table-manager (gra…
f67c486 
…fana#12143)

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@QuantumEnigmaa @MichelHollands
feat: add ciliumnetworkpolicy for world egress for table-manager (gra…
f28a279 
…fana#12143)

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
area/helm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuantumEnigmaa @MichelHollands