-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version info missing #1228
Fix version info missing #1228
Conversation
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
@slim-bean @rfratto @cyriltovena mind hava a look? |
This overlaps some of the work done in #1095, however that PR looks more complete so I'd like to get that merged first and see if we still need this change. |
@slim-bean #1095 not fix this:
|
if you still see this, then you're not using Makefile from #1095. It should look like this:
(it wasn't yet merged) |
oh my mistake, wait for merge! @pstibrany |
Closing in favor of #1095. In case there is still something valuable in here, please open a new PR |
Fix #1208
If
GO111MODULE
does not turn on, set mod as vendor would make version info miss,Signed-off-by: Xiang Dai 764524258@qq.com