fix: use nanosecond precision for timestamp in compacted tsdb index file names #12502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poyzannur
approved these changes
Apr 8, 2024
poyzannur
reviewed
Apr 8, 2024
| @@ -79,7 +79,7 @@ func (i SingleTenantTSDBIdentifier) Hash(h hash.Hash32) (err error) { | |||
| func (i SingleTenantTSDBIdentifier) str() string { | |||
| return fmt.Sprintf( | |||
| "%d-%s-%d-%d-%x.tsdb", | |||
| i.TS.Unix(), | |||
| i.TS.UnixNano(), | |||
There was a problem hiding this comment.
SGTM. Can you also get an approval from blooms folks? I wonder if we do any filename parsing assuming it's seconds precision anywhere.
salvacorts
approved these changes
Apr 8, 2024
1 task
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Do the same changes as PR #11277, i.e., have a creation timestamp in compacted index files with nanosecond precision instead of seconds. I had only made that change for
boltdb-shipperand skipped changingtsdbsincetsdbindex file names have checksums in them. However, as seen in issue #12500, we can hit the bug if compaction happens twice in the same unix second, and it ends up having the same contents in the compacted index(hence the same checksum as well).Which issue(s) this PR fixes:
Fixes #12500
Checklist