Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix mangled admonition block in alerting/recording rule docs #12733

Merged
merged 1 commit into from
Apr 22, 2024
Merged

docs: Fix mangled admonition block in alerting/recording rule docs #12733

merged 1 commit into from
Apr 22, 2024

Conversation

seizethedave
Copy link
Contributor

What this PR does / why we need it:

Fix this formatting that exists in main today.

Before:
image

After:
image

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@seizethedave seizethedave requested a review from a team as a code owner April 22, 2024 19:17
@CLAassistant
Copy link

CLAassistant commented Apr 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 22, 2024
JStickler
JStickler approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Thanks for fixing this!

@JStickler JStickler merged commit c825dba into main Apr 22, 2024
60 checks passed
@JStickler JStickler deleted the seizethedave-rule-doc branch April 22, 2024 19:36
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

grafanabot pushed a commit that referenced this pull request Apr 22, 2024
@seizethedave @grafana-delivery-bot
docs: Fix mangled admonition block in alerting/recording rule docs (#…
8807590 
…12733)

(cherry picked from commit c825dba)
@grafanabot grafanabot mentioned this pull request Apr 22, 2024
Merged
7 tasks
mattgialelis pushed a commit to mattgialelis/loki that referenced this pull request Apr 23, 2024
@seizethedave @mattgialelis
docs: Fix mangled admonition block in alerting/recording rule docs (g…
dc285b4 
…rafana#12733)
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
backport release-3.0.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seizethedave @CLAassistant @grafanabot @JStickler