Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/ingester: check that ingester is in LEAVING state when transferring chunks and claiming tokens. Required when using memberlist client. #1300

Merged
merged 4 commits into from
Dec 6, 2019
Merged

pkg/ingester: check that ingester is in LEAVING state when transferring chunks and claiming tokens. Required when using memberlist client. #1300

merged 4 commits into from
Dec 6, 2019

Commits on Nov 21, 2019

  1. On chunks transfer, verify that source ingester is LEAVING 

    This is important when using gossiping ring. If source ingester is not
leaving yet, than claiming its tokens will fail (merge function
will not move ownership to the target ingester), and target ingester
will end up with no tokens in the ring.
    @pstibrany
    pstibrany committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    e8e75b3 View commit details
    Browse the repository at this point in the history

  2. Register ring to prometheus. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    764e8f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2019

  1. Update check using latest version from Cortex. 

    There is no direct usage of logging, which is consistent
with the rest of this method.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    0f77dab View commit details
    Browse the repository at this point in the history

  2. Move import to group of imports with third-party packages. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    89ccb69 View commit details
    Browse the repository at this point in the history