Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Re-introduce fixed size memory pool for bloom querier #13172

Merged
merged 5 commits into from
Jun 20, 2024
Merged

perf: Re-introduce fixed size memory pool for bloom querier #13172

merged 5 commits into from
Jun 20, 2024

Commits on Jun 19, 2024

  1. perf: Introduce fixed size memory pool for bloom querier 

    ---

Revert "fix(regression):  reverts #13039 to prevent use-after-free corruptions (#13162)"

This reverts commit 41c5ee2.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    ad79a80 View commit details
    Browse the repository at this point in the history

  2. Remove package global variable for bloom page allocator 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f812072 View commit details
    Browse the repository at this point in the history

  3. Fix constructor for BytePool 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    69bd2f7 View commit details
    Browse the repository at this point in the history

  4. Fix merge conflicts 

    Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    40ccf84 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Implement code review suggestion 

    Move `Allocatior()` function from base interface to "extended" store
interface, like it was done for `BloomMetrics()`.

Additionally renamed `Store` to `StoreBase` (which is implemented by all
stores, also the individual store entries) and `StoreWithMetrics` to
`Store`, because this is the main interface that is used.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
    @chaudum
    chaudum committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5221ff9 View commit details
    Browse the repository at this point in the history