Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v1 label API to be Prometheus-compatible #1322

Merged
merged 2 commits into from
Nov 26, 2019

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Nov 26, 2019

The label and label values API will now return the expected form of:

{
  "status": "success",
  "data": [
    "label1",
    "label2",
    "labeln"
  ]
}

Fixes #1293.

The label and label values API will now return the expected form
of:

```json
{
  "status": "success",
  "data": [
    "label1",
    "label2",
    "labeln"
  ]
}
```
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rfratto rfratto merged commit 822e94f into grafana:master Nov 26, 2019
@rfratto rfratto deleted the fix-label-api branch November 26, 2019 15:53
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* Use go.etcd.io/bbolt import and vendor master etcd to we don't import github.com/coreos/...
* Move code around - start a kv package with the interface, and subpackages for consul and etcd.
* Add prefix to the config of the kvstore.  NB This removed the `-consul.prefix` flag.
* Split codec into its own package and prefix client into separate files.
* Add unit tests and etcd mock.
* Remove Client.PutBytes - its only used in one test, can be done with a CAS, and doesn't fit rest of interface with Codecs etc.
* Instrument all ring clients, and add comments.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana cannot read label values from Loki response
3 participants