-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blooms): Fix panic in bloom gateway #13303
Conversation
The slice of block queriers can contain `nil` values, which causes nip pointer dereference when calling `Close()` on them. The regression was introduced with PR #13288 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a hotfix! Can we avoid inserting nil values into the slice instead as a long-term fix or is there a good reason for doing that?
There is a reason why we have |
What this PR does / why we need it:
The slice of block queriers can contain
nil
values, which causes nip pointer dereference when callingClose()
on them.The regression was introduced with PR #13288
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR