Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): ensure tokenizer cache is reset between series #13370

Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jul 1, 2024

Fixes bug where ngrams were not added to blooms b/c they had been added previously to a potentially different series. This caused blooms to fail membership tests incorrectly.

@owen-d owen-d requested a review from a team as a code owner July 1, 2024 20:19
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d force-pushed the blooms/reset-tokenizer-cache-between-series branch from 94fa5fc to f95eab1 Compare July 1, 2024 23:02
@owen-d owen-d merged commit 04bc3a4 into grafana:main Jul 1, 2024
60 checks passed
@chaudum chaudum added type/bug Somehing is not working as expected backport k209 labels Jul 2, 2024
grafanabot pushed a commit that referenced this pull request Jul 2, 2024
chaudum pushed a commit that referenced this pull request Jul 2, 2024
…ries (#13371)

Backport 04bc3a4 from #13370

---

Fixes bug where ngrams were not added to blooms b/c they had been added previously to a potentially different series. This caused blooms to fail membership tests incorrectly.

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
grafanabot pushed a commit that referenced this pull request Jul 2, 2024
grafanabot pushed a commit that referenced this pull request Jul 2, 2024
chaudum pushed a commit that referenced this pull request Jul 2, 2024
…ries (#13374)

Backport 04bc3a4 from #13370

---

Fixes bug where ngrams were not added to blooms b/c they had been added previously to a potentially different series. This caused blooms to fail membership tests incorrectly.

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
chaudum pushed a commit that referenced this pull request Jul 2, 2024
…ries (#13373)

Backport 04bc3a4 from #13370

---

Fixes bug where ngrams were not added to blooms b/c they had been added previously to a potentially different series. This caused blooms to fail membership tests incorrectly.

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants