Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use prefixed WAL storage path in Object Storage #13377

Merged
merged 4 commits into from
Jul 3, 2024
Merged

feat: Use prefixed WAL storage path in Object Storage #13377

merged 4 commits into from
Jul 3, 2024

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Jul 2, 2024

What this PR does / why we need it:

  • Sets the name for the stored WAL segment to be a ULID with a prefix used only by this ingester.
  • This will need more work as the entropy source is not concurrent safe & will probably collide with another instance of the ingester, but I wanted to namespace the object path before trying this code against a real object store to avoid polluting it.

Which issue(s) this PR fixes:
Partial implements https://github.com/grafana/loki-private/issues/1020

@benclive benclive requested a review from a team as a code owner July 2, 2024 11:01
cyriltovena
cyriltovena approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena
Copy link
Contributor

Merge at your will !

Base automatically changed from grobinson/ingester-rf1 to main July 3, 2024 15:53
@benclive benclive force-pushed the benclive/rf1-set-wal-object-name branch from 64e8fd6 to 8da2bb3 Compare July 3, 2024 15:57
@benclive benclive force-pushed the benclive/rf1-set-wal-object-name branch from 1b1d8f4 to e7b220b Compare July 3, 2024 16:13
@benclive benclive merged commit 973aa2d into main Jul 3, 2024
60 checks passed
@benclive benclive deleted the benclive/rf1-set-wal-object-name branch July 3, 2024 16:47
This was referenced Jul 8, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
This was referenced Aug 15, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 23, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 7, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 14, 2024
Open
This was referenced Oct 21, 2024
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@vlad-diachenko vlad-diachenko vlad-diachenko approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benclive @cyriltovena @vlad-diachenko